fix: by default hide cancel #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tagged-release/cms-support #696 +/- ##
==============================================================
+ Coverage 91.86% 91.89% +0.02%
==============================================================
Files 110 111 +1
Lines 4069 4082 +13
Branches 1125 1130 +5
==============================================================
+ Hits 3738 3751 +13
Misses 310 310
Partials 21 21
Continue to review full report at Codecov.
|
cwoolum
previously approved these changes
Oct 12, 2022
hein-j
reviewed
Oct 12, 2022
SwaySway
force-pushed
the
fix/default-hide-cancel
branch
from
80d3990 to
7152ffb
Compare
SwaySway
changed the base branch from
tagged-release/forms-and-views
to
tagged-release/cms-support
SwaySway
force-pushed
the
fix/default-hide-cancel
branch
from
af1cffe to
4df3534
Compare
cwoolum
approved these changes
Oct 22, 2022
hein-j
approved these changes
Oct 22, 2022
zchenwei
added a commit
that referenced
this pull request
Nov 17, 2022
* feat: init form support for has-one relationship (#718) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: wrap relationship fields in ArrayField (#719) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: split up form-renderer-helper (#720) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: map props on relationship-based Autocomplete (#721) Co-authored-by: Hein Jeong <heinje@amazon.com> * feat: add relationship suggestion query to forms (#722) * feat: add relationship suggestion query * chore: map props on relationship-based Autocomplete (#721) Co-authored-by: Hein Jeong <heinje@amazon.com> * feat: add relationship suggestion query * fix: remove extra declarations Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Hein Jeong <73264629+hein-j@users.noreply.github.com> Co-authored-by: Hein Jeong <heinje@amazon.com> * fix: hide cancel button by default (#696) * chore: modify ArrayField to support has-one relationships (#724) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: support not-model HAS_ONE relationships (#726) Co-authored-by: Hein Jeong <heinje@amazon.com> * chore: map type file for model fields (#727) Co-authored-by: Hein Jeong <heinje@amazon.com> * feat: add handling for excluded sectional elements * fix: cli test fix * fix: handle association breaking changes for new schema * Add support for "belongsTo" relationships for create forms (#755) * feat: wip belongs to support * feat: belongsTo working for create form * chore: add golden file for belongsTo create form * fix: arrayfield/autocomplete bugs * chore: update snapshots * chore: handle review comments * chore: add tests and update snapshots * feat: adding many to many support for form creation * test: fix tests * test: fix test * feat: adding many-to-many relationship create form golden file * chore: update create file * test: fix test * test: fix unit tests * test: fix tests * fix: fix merge conflicts * test: fix timestamp type * chore: add tag update form golden file with manyToMany relationship Co-authored-by: Hein Jeong <73264629+hein-j@users.noreply.github.com> Co-authored-by: Hein Jeong <heinje@amazon.com> Co-authored-by: Scott Young <snyoung@gmail.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Josue Ruiz <7465495+SwaySway@users.noreply.github.com> Co-authored-by: Roshane Pascual <rotp@amazon.com> Co-authored-by: Brandon Lyons <lyonsbp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
asana task: https://app.asana.com/0/1202185248783861/1203024227380062/f
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.